Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ops] Bump node-sass from v8.0.0 to v9.0.0 #171863

Closed
wants to merge 1 commit into from
Closed

[Ops] Bump node-sass from v8.0.0 to v9.0.0 #171863

wants to merge 1 commit into from

Conversation

watson
Copy link
Contributor

@watson watson commented Nov 23, 2023

Only breaking change is dropped support for Node.js 14. See release notes: https://github.com/sass/node-sass/releases/tag/v9.0.0

@watson watson added release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release labels Nov 23, 2023
@watson watson requested a review from a team November 23, 2023 13:27
@watson watson self-assigned this Nov 23, 2023
@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 23, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Integration Tests #3 / builds a generated plugin into a viable archive

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @watson

@watson
Copy link
Contributor Author

watson commented Nov 23, 2023

Turns out sass-loader, which uses node-sass, doesn't support this new version (technically it does, but it has a version check that throws, which means it doesn't even try 🙄). So we'd have to upgrade sass-loader to a newer version first, but the next version of sass-loader requires Webpack 5 (#89741), which we're not using yet, so this PR is blocked because of it. So maybe it's easier to just replace node-sass with sass 🤷 (#161813)

@watson watson added the blocked label Nov 23, 2023
@watson watson marked this pull request as draft November 23, 2023 14:01
@watson watson closed this Jan 10, 2024
@watson watson deleted the bump-node-sass branch January 10, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@watson watson

Labels
backport:all-open Backport to all branches that could still receive a release blocked release_note:skip Skip the PR/issue when compiling release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@watson @kibana-ci